teraslice esm migration #3511
teraslice esm migration #3511
Conversation
…amic import for teraslice
packages/teraslice/jest.config.js
Outdated
|
|
||
| const config = module.default(dirPath); | ||
|
|
||
| config.preset = "ts-jest/presets/default-esm"; |
There was a problem hiding this comment.
Didn't we get rid of ts-jest, is this config still necessary?
There was a problem hiding this comment.
we are still using ts-jest for almost the rest of the packages so its not removed, going to do this library by library and not mess with things that work untill we can remove it all after conversion.
| @@ -1,14 +1,3 @@ | |||
| // TODO: see if I can fix this | |||
| function hasKafkaConnector() { | |||
There was a problem hiding this comment.
Do you know why this was originally added?
There was a problem hiding this comment.
to conditionally add default configuration if the library is being used, I just made it so its always there
| this.gcStats = require('gc-stats')(); | ||
| // @ts-expect-error | ||
| const stats = await import('gc-stats'); | ||
| console.log('stats', stats); |
There was a problem hiding this comment.
| console.log('stats', stats); |
Do we still want this console.log?
There was a problem hiding this comment.
this is a good catch, looking into it
There was a problem hiding this comment.
I think this is the only thing you need to actually resolve on this PR prior to merge.
Please let me know when you're done and want review again.
Issues:
@swc/jestfor typescript compiling for jest testing is causing errors with class decorators, so I am keeping ts-jest for the rest of the tests and using the new one until it can be properly configured